username/esp32-hacking
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 9 Wiki Activity

fix: Resolve cppcheck shadow variable and uninitvar warnings
Some checks failed
Lint & Build / Security Flaw Analysis (push) Successful in 15s
Details
Lint & Build / Secret Scanning (push) Successful in 5s
Details
Lint & Build / C/C++ Static Analysis (push) Successful in 34s
Details
Lint & Build / Build Firmware (push) Failing after 1m23s
Details

Browse Source 
Rename local 'arg' to 'val' in serial_task to avoid shadowing the
function parameter. Guard staged memcpy with nsub > 0 to satisfy
cppcheck uninitvar analysis.
This commit is contained in:
user
2026-02-14 23:06:51 +01:00
parent c895f52151
commit 54640a733b
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
get-started/csi_recv_router/main/app_main.c
View File

@@ -1012,7 +1012,8 @@ static void adaptive_task(void *arg)
}
/* Atomically gate: zero nsub first, copy, then set nsub */
s_baseline_nsub = 0;
memcpy(s_baseline_amps, staged, nsub * sizeof(float));
if (nsub > 0)
memcpy(s_baseline_amps, staged, nsub * sizeof(float));
s_baseline_nsub = nsub;
config_save_blob("bl_amps", s_baseline_amps, nsub * sizeof(float));
config_save_i8("bl_nsub", (int8_t)nsub);
@@ -2583,17 +2584,17 @@ static void serial_task(void *arg)
else
printf("OK AUTH off\n");
} else if (strncasecmp(line, "AUTH ", 5) == 0) {
const char *arg = line + 5;
if (strcasecmp(arg, "OFF") == 0) {
const char *val = line + 5;
if (strcasecmp(val, "OFF") == 0) {
s_auth_secret[0] = '\0';
config_erase_key("auth_secret");
printf("OK AUTH off (cleared)\n");
} else {
size_t alen = strlen(arg);
size_t alen = strlen(val);
if (alen < 8 || alen > 64) {
printf("ERR secret length 8-64 chars\n");
} else {
strncpy(s_auth_secret, arg, sizeof(s_auth_secret) - 1);
strncpy(s_auth_secret, val, sizeof(s_auth_secret) - 1);
s_auth_secret[sizeof(s_auth_secret) - 1] = '\0';
config_save_str("auth_secret", s_auth_secret);
printf("OK AUTH on secret=%s\n", s_auth_secret);