username/derp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: always pass server_hostname for Mumble TLS on pre-connected socket

Browse Source 
asyncio.open_connection(sock=..., ssl=...) requires server_hostname
even when check_hostname is disabled. Pass self._host unconditionally.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
user
2026-02-21 21:21:33 +01:00
parent 9d4cb09069
commit b074356ec6
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/derp/mumble.py
View File

@@ -342,9 +342,8 @@ class MumbleBot:
), ),
) )
ssl_ctx = self._create_ssl_context() ssl_ctx = self._create_ssl_context()
hostname = self._host if self._tls_verify else None
self._reader, self._writer = await asyncio.open_connection( self._reader, self._writer = await asyncio.open_connection(
sock=sock, ssl=ssl_ctx, server_hostname=hostname, sock=sock, ssl=ssl_ctx, server_hostname=self._host,
) )
async def _send_msg(self, msg_type: int, payload: bytes = b"") -> None: async def _send_msg(self, msg_type: int, payload: bytes = b"") -> None: