Fix critical playbook execution errors in system_info role
Fix three critical errors preventing playbook execution: 1. Ansible syntax error in hypervisor detection 2. Missing OS-specific variable files 3. Invalid inventory plugin configuration Changes to roles/system_info/tasks/detect_hypervisor.yml: - Fix invalid failed_when at block level (line 75) - Move failed_when: false to individual tasks within the block - Ansible blocks don't support failed_when attribute directly - Each libvirt detection task now has failed_when: false Changes to roles/system_info/vars/: - Create Debian.yml with Debian/Ubuntu specific variables - Create RedHat.yml with RHEL/CentOS/Rocky/Alma variables - Create Suse.yml with SUSE/openSUSE variables - Define OS-specific package names and paths - Fixes "Could not find or access 'Debian.yml'" error Changes to inventories/development/libvirt_kvm.yml: - Fix plugin name: libvirt_kvm → community.libvirt.libvirt - Update URI to use local system: qemu:///system - Fix compose variables: use ansible_libvirt_* prefix - Fix groups conditions to use ansible_libvirt_state - Fix keyed_groups to use ansible_libvirt_* variables - Remove unsupported hypervisors array configuration - Add strict: false for graceful error handling Error details fixed: ERROR 1: 'failed_when' is not a valid attribute for a Block Location: detect_hypervisor.yml:42 Solution: Moved to individual tasks ERROR 2: Could not find or access 'Debian.yml' Location: roles/system_info/vars/ Solution: Created OS-specific variable files ERROR 3: inventory config specifies unknown plugin 'libvirt_kvm' Location: inventories/development/libvirt_kvm.yml Solution: Corrected to community.libvirt.libvirt Testing: These fixes resolve the playbook syntax errors and allow the gather_system_info playbook to run successfully on available hosts. Related to: ROLE_ANALYSIS_AND_IMPROVEMENTS.md recommendations 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
@@ -45,34 +45,38 @@
|
||||
shell: virsh version
|
||||
register: system_info_libvirt_version_raw
|
||||
changed_when: false
|
||||
failed_when: false
|
||||
become: true
|
||||
|
||||
- name: List libvirt networks
|
||||
shell: virsh net-list --all
|
||||
register: system_info_libvirt_networks_raw
|
||||
changed_when: false
|
||||
failed_when: false
|
||||
become: true
|
||||
|
||||
- name: List libvirt storage pools
|
||||
shell: virsh pool-list --all
|
||||
register: system_info_libvirt_pools_raw
|
||||
changed_when: false
|
||||
failed_when: false
|
||||
become: true
|
||||
|
||||
- name: Count running VMs
|
||||
shell: virsh list --state-running | grep -c running || echo "0"
|
||||
register: system_info_libvirt_running_vms_raw
|
||||
changed_when: false
|
||||
failed_when: false
|
||||
become: true
|
||||
|
||||
- name: Count total VMs
|
||||
shell: virsh list --all | tail -n +3 | grep -v "^$" | wc -l
|
||||
register: system_info_libvirt_total_vms_raw
|
||||
changed_when: false
|
||||
failed_when: false
|
||||
become: true
|
||||
|
||||
when: "'available' in system_info_virsh_check_raw.stdout"
|
||||
failed_when: false
|
||||
tags: [gather, hypervisor, libvirt]
|
||||
|
||||
- name: Check for Proxmox VE
|
||||
|
||||
19
roles/system_info/vars/Debian.yml
Normal file
19
roles/system_info/vars/Debian.yml
Normal file
@@ -0,0 +1,19 @@
|
||||
---
|
||||
# OS-specific variables for Debian family (Debian, Ubuntu)
|
||||
|
||||
# Package names for Debian/Ubuntu
|
||||
system_info_packages:
|
||||
- lshw
|
||||
- dmidecode
|
||||
- pciutils
|
||||
- usbutils
|
||||
- smartmontools
|
||||
- ethtool
|
||||
- sysstat
|
||||
|
||||
# Service names
|
||||
system_info_audit_service: auditd
|
||||
|
||||
# Paths
|
||||
system_info_resolv_conf: /etc/resolv.conf
|
||||
system_info_network_interfaces: /etc/network/interfaces
|
||||
19
roles/system_info/vars/RedHat.yml
Normal file
19
roles/system_info/vars/RedHat.yml
Normal file
@@ -0,0 +1,19 @@
|
||||
---
|
||||
# OS-specific variables for RedHat family (RHEL, CentOS, Rocky, AlmaLinux)
|
||||
|
||||
# Package names for RedHat/CentOS/Rocky/AlmaLinux
|
||||
system_info_packages:
|
||||
- lshw
|
||||
- dmidecode
|
||||
- pciutils
|
||||
- usbutils
|
||||
- smartmontools
|
||||
- ethtool
|
||||
- sysstat
|
||||
|
||||
# Service names
|
||||
system_info_audit_service: auditd
|
||||
|
||||
# Paths
|
||||
system_info_resolv_conf: /etc/resolv.conf
|
||||
system_info_network_config: /etc/sysconfig/network-scripts/
|
||||
19
roles/system_info/vars/Suse.yml
Normal file
19
roles/system_info/vars/Suse.yml
Normal file
@@ -0,0 +1,19 @@
|
||||
---
|
||||
# OS-specific variables for SUSE family (SLES, openSUSE)
|
||||
|
||||
# Package names for SUSE/openSUSE
|
||||
system_info_packages:
|
||||
- lshw
|
||||
- dmidecode
|
||||
- pciutils
|
||||
- usbutils
|
||||
- smartmontools
|
||||
- ethtool
|
||||
- sysstat
|
||||
|
||||
# Service names
|
||||
system_info_audit_service: auditd
|
||||
|
||||
# Paths
|
||||
system_info_resolv_conf: /etc/resolv.conf
|
||||
system_info_network_config: /etc/sysconfig/network/
|
||||
Reference in New Issue
Block a user